• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
adding missing displayed_object_id, to get CKfinder working

improve spelling

  1. … 14 more files in changeset.
Use 'attachments::detach_url' instead of building manually the URL

Remove form debug code

Forum attachments reform.

- Add new style of attachments to the forums, allowing multiple attachments to a single message directly from the message post page, using the multiple file input widget.

- Retain compatibility with old style attachments, using the new 'AttachmentStyle' package instance parameter. Currently, this supports two values: 'simple' (new behavior) and 'complex' previous behavior.

- Both attachment styles can coexist, and attachments added by any of such methods will be shown.

- Improve the contract on 'forums/lib/message/post.tcl'.

- Show attachments on message preview.

- Bump version number.

Add 'alt_template' to include contract

Add include contract and 'preview' view to the attachment list

Require admin privileges for attachment deletion in the forum, the same as for message editing

Put the delete link to the right of the attachment

Add the 'detach' option on the attachment list, for users with write permissions on the message

Center icons on attachment list

Generalize attachment size logic in forum posts, so different object types, such as 'content_item', 'content_revision', and their subtypes, are supported

    • -15
    • +33
    ./lib/message/attachment-list.tcl
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 41 more files in changeset.
Improve content_type detection on forum attachments, and avoid redirecting to external hosts on URLs

Url attachments in forums: use URL icon and avoid showing the size

Show attachment size in forum messages

Whitespace changes

Use the attachment icon, available since 10+ years, for forums attachments.

Use same capitalization policy as other message keys in the same form. Bump version to reload message keys.

Only show the possibility to allow/disallow attachments in the forum new/edit pages if the attachments package is already mounted under the forums package instance

Update italian localization

  1. … 1 more file in changeset.
Whitespace changes

Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

Cleanup trailing whitespace

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

    • -0
    • +15
    ./sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -1
    • +4
    ./sql/postgresql/forums-forums-create.sql
file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
Initialize d variable

Fix call parameters

- prefer "last_request" over "user_id" in automated tests

- make web test more robust against local language dependencies