• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix typos

enforce the system locale for the resolver test

replace anonymous array by Tcl dicts

reduce XOTcl 1.* idioms

modernize code: use resolver variables rather than method calls

    • -59
    • +56
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
extend test cases

add safety belt and hint for pretty_link invocations with unknown target pages

    • -1
    • +12
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
remove xotcl-1 idioms

    • -9
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
fix potential confusion for test cases: make sure, the provided name and nls_language are aligned

    • -3
    • +7
    /openacs-4/packages/xowiki/www/admin/test.tcl
add checking for javascript and data protocols (fixes issue #3413)

fix broken test cases

make debugging line more meaningful

Adapt proc doc to implementation, as we are dealing with files in general, instead of only images.

Comment log statement: found_id might not be an object by the time this code is executed

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
whitespace changes

add test for ambiguous page link with language prefix

add page p0 to regression test, provide more logging

    • -3
    • +6
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
reduce verbosity

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
As stated in xowiki::Package.item_ref, a trailing slash indicates a folder in case of ambiguity

Use a safer varname for xowf tests as well

As apparently test init cases can pollute each other's namespace, use a different variable name

Add page contract

Add ad_include_contract

    • -2
    • +8
    /openacs-4/packages/faq/lib/faq-add-edit.tcl
Replace string equal idiom

fix argument order in link renderer

use consistently the instance variable of the package_id

Do not depend on XoTcl in the core

Make test independent from vars defined elsewhere

Whitespace changes

Use 'lc_content_size_pretty' for content size